PHPC-1031: Run configure check to use ASN1_STRING_get0_data over ASN1_STRING_data in bundled libmongoc #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_STRING_data in bundled libmongoc
jmikola
reviewed
Nov 10, 2017
| @@ -295,6 +295,8 @@ if test "$MONGODB" != "no"; then | |||
| AC_SUBST(MONGOC_ENABLE_SSL, 1) | |||
| AC_SUBST(MONGOC_ENABLE_CRYPTO_LIBCRYPTO, 1) | |||
| AC_SUBST(MONGOC_ENABLE_SSL_OPENSSL, 1) | |||
|
|
|||
| AC_CHECK_DECLS([ASN1_STRING_get0_data], [AC_SUBST(MONGOC_HAVE_ASN1_STRING_GET0_DATA, 1)], [AC_SUBST(MONGOC_HAVE_ASN1_STRING_GET0_DATA, 1)], [[#include <openssl/asn1.h>]]) | |||
There was a problem hiding this comment.
Assuming this is for OpenSSL 1.1, we might need a similar check in this part of config.w32. That could be done by checking if SETUP_OPENSSL() returns 2.
jmikola
approved these changes
Nov 13, 2017
derickr
added a commit
that referenced
this pull request
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1031