PHPC-1006: Do not modify Persistable::bsonSerialize() retval #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjori
reviewed
Sep 5, 2017
| @@ -556,6 +566,10 @@ void php_phongo_zval_to_bson(zval *data, php_phongo_bson_flags_t flags, bson_t * | |||
| goto cleanup; | |||
| } | |||
|
|
|||
| if (skip_odm_field && !strcmp(string_key, PHONGO_ODM_FIELD_NAME)) { | |||
There was a problem hiding this comment.
Its confusing that string_key is both a char* and a zend_string.
but that might just be the context given github, which was very badly broken :|
There was a problem hiding this comment.
This diff line is for the PHP 5.x block, where string_key is the char* populated by zend_hash_get_current_key_ex(). In the preceding PHP 7.x block, ZEND_HASH_FOREACH_KEY_VAL() assigns the zend_string.
|
I've no idea why this is failing on Travis but this lgtm |
Fixed in #644 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1006