Skip to content

Use string literal php_array macros where possible #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2016
Merged

Use string literal php_array macros where possible #409

merged 1 commit into from
Sep 16, 2016

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Sep 15, 2016

This updates a few cases where we were already passing string literals to the php_array macros. The "c" variant expands to lit, sizeof(lit) - 1 instead of lit, strlen(lit).

@derickr
Copy link
Contributor

derickr commented Sep 16, 2016

LGTM

@jmikola jmikola merged commit b6296f7 into mongodb:master Sep 16, 2016
jmikola added a commit that referenced this pull request Sep 16, 2016
@jmikola
Merge pull request #409
8170399
@jmikola jmikola deleted the php_array branch September 16, 2016 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmikola @derickr