Skip to content

PHPC-552: Implement ObjectID::getTimestamp() method #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2016

Conversation

derickr
Copy link
Contributor

@derickr derickr commented Sep 5, 2016

No description provided.

@@ -134,6 +134,24 @@ PHP_METHOD(ObjectID, __construct)
}
/* }}} */

/* {{{ proto string ObjectID::getTimestamp()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method returns an integer.

@jmikola
Copy link
Member

jmikola commented Sep 6, 2016

LGTM with the proto revision.

@derickr derickr force-pushed the PHPC-552-objectid-gettimestamp branch from 44baf52 to 915a494 Compare September 7, 2016 10:10
@derickr derickr force-pushed the PHPC-552-objectid-gettimestamp branch from 915a494 to e912db7 Compare September 7, 2016 10:16
@derickr derickr merged commit e912db7 into mongodb:master Sep 7, 2016
derickr added a commit that referenced this pull request Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants