PHPC-2584: Run driver test with system libraries #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
May 23, 2025
| - name: Add repository | ||
| shell: bash | ||
| working-directory: /tmp | ||
| # Note: no packages for Ubuntu 24.04 noble exist, so we use those for 22.04 |
There was a problem hiding this comment.
Are there any plans to have one later? If not, it will get complicated when the upgrade to Ubuntu 24.04 is enforced by GitHub.
There was a problem hiding this comment.
I created MONGOCRYPT-813 for this. Note that I'm already using 24.04 and the PPA works for the time being. Once the ticket is resolved, I'd update this accordingly.
|
|
||
| - name: Install libmongocrypt | ||
| shell: bash | ||
| run: sudo apt-get install -y libmongocrypt-dev |
There was a problem hiding this comment.
It might be possible to cache the apt dependency: https://github.com/marketplace/actions/cache-apt-packages
There was a problem hiding this comment.
Noted for a separate PR.
GromNaN
approved these changes
May 23, 2025
alcaeus
force-pushed
the
feature/phpc-2435-libmongoc-2
branch
from
9ef16ef to
b5f3c8e
Compare
alcaeus
force-pushed
the
build-system-libs
branch
from
15db850 to
9949485
Compare
alcaeus
merged commit 71510e2
into
mongodb:feature/phpc-2435-libmongoc-2
61 checks passed
alcaeus
added a commit
that referenced
this pull request
Jun 3, 2025
* Bump libmongoc to 2.0.1 and libmongocrypt to 1.14.0 This fixes the following issues: * PHPC-2581: Bump to libmongoc 2.0.1 * PHPC-2578: Bump to libmongocrypt 1.14.0 * PHPC-2548: Remove MONGOC_WRITE_CONCERN_W_ERRORS_IGNORED * PHPC-2540: Use const for mongoc_host_list_t * PHPC-2547: Remove MONGOC_NO_AUTOMATIC_GLOBALS * PHPC-2549: Remove BSON_EXTRA_ALIGN * PHPC-1548: Add tests for empty authSource URI option * PHPC-2542: Add test coverage for auth mechanism errors * PHPC-2584: Run driver test with system libraries (#1831) * Add build action to build libmongoc system libraries * Build driver with system libs * Install libmongocrypt as system library * Run tests with system libs * Move system library tests to tests workflow * PHPC-2545: Drop support for compiling with LibreSSL (#1836) * PHPC-2545: Drop support for compiling with LibreSSL * Warn when explicitly building with libressl * Fix usage of wrong version variable * PHPC-2367: Add SSPI SASL, drop Cyrus on Windows (#1837) * Support building with SSPI support under Windows * Remove support for building with Cyrus SASL on Windows * Apply feedback from Copilot * Apply code review feedback * Fix handling of missing SASL libs when relying on default value for with-mongodb-sasl * Apply feedback from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-2584
This PR adds tests with system libraries to ensure that the driver can function when built not with the bundled versions of libmongoc and libmongocrypt, but instead is able to locate and build with system libraries. I'm using GitHub Actions for this build as it's easier to isolate this build from others on this platform. The process is relatively simple:
--with-mongodb-system-libs=yesconfigure optionmake show-configoutput so this can be verified)Once we merge the feature branch to v2.x, I would also mark this particular build as required so any breakage when building with system libs prevents a merge.