Skip to content

Remove prefix ext- from extension name. #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

macintoshplus
Copy link
Contributor

See #1750.

Remove the wrong extension name prefix into composer.json configuration used by php/pie.

@alcaeus
Copy link
Member

alcaeus commented Nov 19, 2024

Ah, I forgot that the guidance was updated to exclude the ext- prefix. Do you mind re-targeting v1.20 for this change? You can do so by resetting your branch to v1.20, then cherry-picking the above commit onto it and force-pushing to this PR.

Also, if you'd like to apply this contribution to more extensions, I saw that xdebug also includes the ext- prefix in its name.

@macintoshplus macintoshplus changed the base branch from v1.x to v1.20 November 19, 2024 11:59
@macintoshplus macintoshplus changed the base branch from v1.20 to v2.x November 19, 2024 11:59
@macintoshplus macintoshplus changed the base branch from v2.x to v1.x November 19, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants