PHPC-2347: Deprecate BSON functions #1607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
commented
Jul 10, 2024
| Test#0 { "binary" : { "$binary" : "cmFuZG9tQmluYXJ5RGF0YQ==", "$type" : "00" } } | ||
| string(73) "{ "binary" : { "$binary" : "cmFuZG9tQmluYXJ5RGF0YQ==", "$type" : "00" } }" | ||
| string(73) "{ "binary" : { "$binary" : "cmFuZG9tQmluYXJ5RGF0YQ==", "$type" : "00" } }" | ||
| Test#0 { "binary" : { "$binary" : { "base64" : "cmFuZG9tQmluYXJ5RGF0YQ==", "subType" : "00" } } } |
There was a problem hiding this comment.
The tests all used to print toJSON, which we did not implement in the Document class. Using relaxed extended JSON is responsible for the additional properties.
|
|
||
| function fetch($bson, $typeMap = []) | ||
| { | ||
| for ($i = 0; $i < 25000; $i++) { |
There was a problem hiding this comment.
This test was originally added to check for a memory leak, but I figured that we don't need that regression test, especially since it would create 100000 deprecation notices and thus takes a considerable amount of time to run.
| @@ -809,22 +809,22 @@ function failMaxTimeMS(Server $server) | |||
| } | |||
|
|
|||
| function toPHP($var, $typemap = array()) { | |||
There was a problem hiding this comment.
These are the utility functions I mentioned in the PR description. I'd like to remove these in a separate step for some more efficient handling of data and/or better test output.
| } | ||
| function toJSON($var) { | ||
| return MongoDB\BSON\toJSON($var); | ||
| return MongoDB\BSON\Document::fromBSON($var)->toCanonicalExtendedJSON(); |
There was a problem hiding this comment.
The change from toJSON to toCanonicalExtendedJSON is responsible for most of the test changes.
GromNaN
reviewed
Jul 10, 2024
GromNaN
approved these changes
Jul 10, 2024
alcaeus
added a commit
that referenced
this pull request
Sep 4, 2024
* master: (22 commits) PHPC-2434: Add PHP 8.4 to GitHub Actions (#1625) PHPC-2421, PHPC-2428: Update bundled dependencies (#1622) Don't build libmongoc version in pull requests Use drivers-evergreen-tools for Windows testing (#1615) PHPC-1957 Add tests for out-of-range UTCDateTime values (#1614) PHPC-2286 Implement `UTCDateTime::toDateTimeImmutable` (#1611) PHPC-2414, PHPC-2415: Update wire versions for MongoDB 8.0 compatibility (#1610) PHPC-2349, PHPC-2411: Deprecate unused exception classes (#1608) Fix failing tests on x86 systems (#1609) PHPC-2347: Deprecate BSON functions (#1607) PHPC-1489: Deprecate integer readPreference constants (#1604) Fix version computation for libmongoc development versions (#1599) PHPC-2376: Test against MongoDB 8.0 (#1598) PHPC-2254: Relax server selection timeout error message pattern (#1587) PHPC-2401: Support QEv2 range protocol (#1583) PHPC-2398: Use server_id methods for libmongoc 1.28+ (#1582) PHPC-2395: Fetch Atlas connectivity URIs from AWS Secrets Manager (#1579) Merge v1.19 into master (#1578) Revert "Bump mongodb-labs/drivers-github-tools from 1 to 2 (#1568)" (#1571) Bump mongodb-labs/drivers-github-tools from 1 to 2 (#1568) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-2347
This deprecates all functions in the
MongoDB\BSONnamespace in favour of theMongoDB\BSON\Documentclass. I've changed test usages of these functions to the Document class, except where we specifically want to test the functions. Note that tests often use functions liketoPHPwithout a namespace - these were proxy functions and were changed to use the Document class internally, even though this is not very efficient. I plan to refactor those utility functions in a separate PR. In order to avoid accounting for deprecations in BSON corpus tests, I've removed the corresponding calls in those. Let me know if that's a concern.