Skip to content

Prepare 1.18.1 release #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions phongo_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
* publishing a release. */

/* clang-format off */
#define PHP_MONGODB_VERSION "1.18.1-dev"
#define PHP_MONGODB_VERSION "1.18.2-dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this earlier, but to repeat here: I think the process would benefit from splitting the changes up into separate PRs. That would presumably not require any special merging if automation were to create the tag after the PR is merged (in any fashion). And it would also make reviewing the diff(s) more straightforward since the most meaningful change (the "Packed 1.18.1" commit) would not longer be hidden.

#define PHP_MONGODB_STABILITY "devel"
#define PHP_MONGODB_VERSION_DESC 1,18,1,0
#define PHP_MONGODB_VERSION_DESC 1,18,2,0
/* clang-format on */

#endif /* PHONGO_VERSION_H */