PHPC-1000: Add missing exception #1453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
phpc-1000-add-missing-exception
branch
from
169f236 to
f2a16d3
Compare
jmikola
reviewed
Aug 4, 2023
| @@ -130,6 +130,10 @@ static inline bool phongo_check_bson_serialize_return_type(zval* retval, zend_cl | |||
| return true; | |||
| } | |||
|
|
|||
| phongo_throw_exception(PHONGO_ERROR_UNEXPECTED_VALUE, | |||
| "Expected to receive instance of %s, %s given", | |||
There was a problem hiding this comment.
Indentation looks way off here. Did you run this through clang-format?
There was a problem hiding this comment.
This was changed by CLion when I moved code around. clang-format doesn't care about these indentations, but we typically only indent an additional level for multi-line method calls. I've updated this and two other instances in this file.
jmikola
approved these changes
Aug 4, 2023
jmikola
approved these changes
Aug 4, 2023
alcaeus
force-pushed
the
phpc-1000-add-missing-exception
branch
from
743fd57 to
3e4697b
Compare
Turns out I was wrong before: the change I pushed broke clang-format, so I reverted it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PHPC-1000 to take care of #1449 (review)