PHPC-2263: Detect strerror_r() implementation #1451
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps libmongoc submodule to pull in changes for CDRIVER-4679
jmikola
commented
Aug 1, 2023
| # Check for strerror_r() | ||
|
|
||
| old_CPPFLAGS="$CPPFLAGS" | ||
| dnl PHP 8.2+ defines _GNU_SOURCE by default |
jmikola
commented
Aug 1, 2023
| if test "$PHP_MONGODB_PHP_VERSION_ID" -ge "80200"; then | ||
| CPPFLAGS="$CPPFLAGS -D_GNU_SOURCE" | ||
| fi | ||
| AC_FUNC_STRERROR_R |
There was a problem hiding this comment.
|
This PR was superseded by #1458. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2263
Bumps libmongoc submodule to pull in changes for CDRIVER-4679
Opening this as a draft as CDRIVER-4679 may end up being reverted if libbson is changed to use
strerror_l().