-
Notifications
You must be signed in to change notification settings - Fork 208
PHPLIB-1098: Test on RHEL 8.x #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, the comment above this matrix still states:
Should it be updated to refer to RHEL 7.6 and Ubuntu 22.04 (or perhaps just say all operating systems)?
I'm not convinced that we need to test the alternative architectures with such a wide matrix. Consider moving
rhel83-zseries
andrhel81-power8
to thetest-alt-archs
matrix below (and updating the server/PHP versions as needed).And perhaps you'd like to group the arm64 platforms together as well with a more limited matrix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the comment. As for the range that's tested, the matrix tests all supported PHP versions against the lowest and highest server versions we support. I believe that testing with all PHP versions should be part of the pipeline, but we can consider dropping one of the MongoDB server versions under test.
I'd also be in favour of differentiating between pull request and branch builds. While branch builds should test all platforms and server versions exhaustively, we may get away with limiting testing to PHP edge versions (so lowest and highest supported) in pull requests for these platforms. I'd have to take a look on how we could best configure this, but offering it as a suggestion to narrow down the PR pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM. I concur that we should focus on minimizing the PR builds since that's where most of the overhead comes from.