Skip to content

PHPLIB-1098: Test on RHEL 8.x #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 17 additions & 26 deletions .evergreen/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1139,22 +1139,21 @@ axes:
- id: rhel90
display_name: "RHEL 9.0"
run_on: rhel90-small
# TODO: RHEL 8.x is not working yet
# - id: rhel82-arm64
# display_name: "RHEL 8.2 ARM64"
# run_on: rhel82-arm64-small
# - id: rhel80
# display_name: "RHEL 8.0"
# run_on: rhel80-small
- id: rhel83-zseries
display_name: "RHEL 8.3 Zseries"
run_on: rhel83-zseries-small
- id: rhel82-arm64
display_name: "RHEL 8.2 ARM64"
run_on: rhel82-arm64-small
- id: rhel81-power8
display_name: "RHEL 8.1 Power8"
run_on: rhel81-power8-large
- id: rhel80
display_name: "RHEL 8.0"
run_on: rhel80-small
- id: rhel76
display_name: "RHEL 7.6"
run_on: rhel76-small
- id: rhel71-power8
display_name: "RHEL 7.1 Power 8"
run_on: rhel71-power8-build
- id: rhel72-zseries
display_name: "RHEL 7.2 zSeries"
run_on: rhel72-zseries-build

# Ubuntu LTS
- id: ubuntu2204
Expand Down Expand Up @@ -1209,16 +1208,17 @@ axes:


buildvariants:
# Test all PHP versions with latest-stable MongoDB on Debian 11, Debian 10, RHEL 8.0, Ubuntu 20.04
# Test all PHP versions with latest-stable MongoDB on all operating systems
- matrix_name: "test-php-versions"
matrix_spec:
os:
- debian11
- debian10
- rhel90
# TODO: RHEL 8.x is not working yet
# - rhel82-arm64
# - rhel80
- rhel83-zseries
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, the comment above this matrix still states:

# Test all PHP versions with latest-stable MongoDB on Debian 11, Debian 10, RHEL 8.0, Ubuntu 20.04

Should it be updated to refer to RHEL 7.6 and Ubuntu 22.04 (or perhaps just say all operating systems)?

I'm not convinced that we need to test the alternative architectures with such a wide matrix. Consider moving rhel83-zseries and rhel81-power8 to the test-alt-archs matrix below (and updating the server/PHP versions as needed).

And perhaps you'd like to group the arm64 platforms together as well with a more limited matrix.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the comment. As for the range that's tested, the matrix tests all supported PHP versions against the lowest and highest server versions we support. I believe that testing with all PHP versions should be part of the pipeline, but we can consider dropping one of the MongoDB server versions under test.

I'd also be in favour of differentiating between pull request and branch builds. While branch builds should test all platforms and server versions exhaustively, we may get away with limiting testing to PHP edge versions (so lowest and highest supported) in pull requests for these platforms. I'd have to take a look on how we could best configure this, but offering it as a suggestion to narrow down the PR pipeline.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. I concur that we should focus on minimizing the PR builds since that's where most of the overhead comes from.

- rhel82-arm64
- rhel81-power8
- rhel80
- rhel76
- ubuntu2204-arm64
- ubuntu2204
Expand Down Expand Up @@ -1253,15 +1253,6 @@ buildvariants:
- name: "test-replicaset-auth"
- name: "test-sharded"

# Test RHEL Power8 and zSeries architectures with MongoDB 4.4
- matrix_name: "test-alt-archs"
matrix_spec: { "os": ["rhel71-power8", "rhel72-zseries"], "mongodb-versions": "4.4", "php-edge-versions": "oldest-supported" }
display_name: "${os}, ${mongodb-versions}, ${php-edge-versions}"
tasks:
- name: "test-standalone-ssl"
- name: "test-replicaset-auth"
- name: "test-sharded"

# Test alternative storage engines on MongoDB 4.0
- matrix_name: "test-storage-engines"
matrix_spec: { "os": "debian92", "mongodb-versions": "4.0", "php-edge-versions": "latest-stable", "storage-engine": ["inmemory", "mmapv1"] }
Expand Down