PHPC-2121: Skip failing test #1365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Sep 15, 2022
jmikola
approved these changes
Sep 15, 2022
Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-2121
In an effort to reach a green CI, I decided to skip this failing test since it's tracked as failing-on-waterfall.
As an aside, this sent me down a deep rabbit hole trying to figure out why I couldn't get the test to properly skip. The culprit is the SKIPIF caching introduced in PHP 8.1 (as noticed by @jmikola before - see #1301 and php/php-src#8076). Until we properly fix this,
skip_if_not_cleanhas to be the last SKIPIF check. In a case of not optimising early enough, I added theskip_if_server_versioncheck to the bottom, which causedrun-tests.phpto truncate its output due tonocacheappearing before.