Skip to content

PHPC-2103: Report loaded crypt_shared version in phpinfo() #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Aug 30, 2022

https://jira.mongodb.org/browse/PHPC-2103
https://jira.mongodb.org/browse/PHPC-2132

Note: this was rebased after closing #1352 for PHPC-2131 and merging v1.14 up to master.

@jmikola
Copy link
Member Author

jmikola commented Sep 8, 2022

Note: the one task failure is related to PHPC-2121.

Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version in the libmongoc version file looks off, LGTM otherwise.

OK: Got MongoDB\Driver\Exception\EncryptionException
A crypt_shared override path was specified [/not/found], but we failed to open a dynamic library at that location

OK: Got MongoDB\Driver\Exception\EncryptionException
Option 'cryptSharedLibRequired' is 'true', but failed to load the crypt_shared runtime libary
Option 'cryptSharedLibRequired' is 'true', but failed to load the crypt_shared runtime lib%r(r?)%rary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice way to work around the typo being fixed eventually :)

@alcaeus alcaeus self-requested a review September 13, 2022 17:58
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmikola jmikola merged commit f0421fa into mongodb:master Sep 14, 2022
@jmikola jmikola deleted the phpc-2103 branch September 14, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants