PHPC-2128: Create stub file for functions #1349
Conversation
|
The naming issue upstream is fixed by php/php-src#9406. |
There was a problem hiding this comment.
Minor suggestions but LGTM.
Is the plan to merge this now and then regenerate after php/php-src#9406 is merged? If so, do you want to create a separate tracking ticket for that?
alcaeus
force-pushed
the
feature/phpc-2128
branch
from
4c48866 to
ce3d66f
Compare
alcaeus
force-pushed
the
feature/phpc-2128
branch
from
ce3d66f to
821b577
Compare
If the PR to php-src is merged today, I'd make the changes to avoid circling back to this, but if the PR is delayed I'd merge this down and create a separate ticket for making the changes. |
|
I'll leave this for you to merge on your own time. |
|
Merging now since the PR might take a few more days to be merged. For reference, changes to the stub generation script don't automatically cause a regeneration of the arginfo files, as the stub file hash stored in the arginfo file is not dependent on the generation script. Changes to the script will only take effect when the stub file changes, which protects us from these BC breaks happening randomly. |
PHPC-2128
This adds the last stub file needed to no longer have to write arginfo definitions ourselves. However, there's a small catch to it: due to the way gen_stub.php generates the code, the function entries are not prefixed with their namespace (unlike for methods where they are prefixed by the class name, which includes the namespace). This essentially means that as soon was we want to have a function with one name in two separate namespaces, the autogenerated file will no longer work, as shown in this gist.
I'm fine with this for now and am working to improve gen_stub upstream to fix this issue; however we can also defer this until the upstream script is fixed.