Skip to content

PHPC-2124: Ensure that null is still accepted for optional parameters #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2022
Merged

PHPC-2124: Ensure that null is still accepted for optional parameters #1347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BSON/Decimal128.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

final class Decimal128 implements Decimal128Interface, \JsonSerializable, Type, \Serializable
{
final public function __construct(string $value = '') {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it this was always inconsistent, as the constructor has always required 1 parameter and uses Z_PARAM_STRING.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct - this may be due to me being lazy and using PHPStorm's stubs as base for these and subsequently forgetting to double-check this method: https://github.com/JetBrains/phpstorm-stubs/blob/9d134fcc6c8d4cbb8ffd8e65e25a49fea18a7a0d/mongodb/mongodb.php#L2015

final public function __construct(string $value) {}

final public function __toString(): string {}

Expand Down
6 changes: 3 additions & 3 deletions src/BSON/Decimal128_arginfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 9481dbe518648d2d64cce460c6c5d73ce9df5c6c */
* Stub hash: be5acdbf8df3109c3c50f10bbd1ab8b4e96875e6 */

ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_BSON_Decimal128___construct, 0, 0, 0)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, value, IS_STRING, 0, "\'\'")
ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_BSON_Decimal128___construct, 0, 0, 1)
ZEND_ARG_TYPE_INFO(0, value, IS_STRING, 0)
ZEND_END_ARG_INFO()

ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_MongoDB_BSON_Decimal128___toString, 0, 0, IS_STRING, 0)
Expand Down
10 changes: 5 additions & 5 deletions src/MongoDB/BulkWrite.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@

final class BulkWrite implements \Countable
{
public final function __construct(array $options = []) {}
public final function __construct(?array $options = null) {}

public function count(): int {}

#if PHP_VERSION_ID >= 80000
public function delete(array|object $filter, array $deleteOptions = []): void {}
public function delete(array|object $filter, ?array $deleteOptions = null): void {}
#else
/** @param array|object $filter */
public function delete($filter, array $deleteOptions = []): void {}
public function delete($filter, ?array $deleteOptions = null): void {}
#endif

#if PHP_VERSION_ID >= 80000
Expand All @@ -31,13 +31,13 @@ public final function insert($document) {}
#endif

#if PHP_VERSION_ID >= 80000
public function update(array|object $filter, array|object $newObj, array $updateOptions = []): void {}
public function update(array|object $filter, array|object $newObj, ?array $updateOptions = null): void {}
#else
/**
* @param array|object $filter
* @param array|object $newObj
*/
public function update($filter, $newObj, array $updateOptions = []): void {}
public function update($filter, $newObj, ?array $updateOptions = null): void {}
#endif

final public function __wakeup(): void {}
Expand Down
12 changes: 6 additions & 6 deletions src/MongoDB/BulkWrite_arginfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 3325b767b4321a1837fa7a8aef924a39e6e6816d */
* Stub hash: 179d375c7c122723254e7b19dd97f8ef33caf38c */

ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_Driver_BulkWrite___construct, 0, 0, 0)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 0, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()

ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_MongoDB_Driver_BulkWrite_count, 0, 0, IS_LONG, 0)
Expand All @@ -11,14 +11,14 @@ ZEND_END_ARG_INFO()
#if PHP_VERSION_ID >= 80000
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_MongoDB_Driver_BulkWrite_delete, 0, 1, IS_VOID, 0)
ZEND_ARG_TYPE_MASK(0, filter, MAY_BE_ARRAY|MAY_BE_OBJECT, NULL)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, deleteOptions, IS_ARRAY, 0, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, deleteOptions, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()
#endif

#if !(PHP_VERSION_ID >= 80000)
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_MongoDB_Driver_BulkWrite_delete, 0, 1, IS_VOID, 0)
ZEND_ARG_INFO(0, filter)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, deleteOptions, IS_ARRAY, 0, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, deleteOptions, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()
#endif

Expand All @@ -38,15 +38,15 @@ ZEND_END_ARG_INFO()
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_MongoDB_Driver_BulkWrite_update, 0, 2, IS_VOID, 0)
ZEND_ARG_TYPE_MASK(0, filter, MAY_BE_ARRAY|MAY_BE_OBJECT, NULL)
ZEND_ARG_TYPE_MASK(0, newObj, MAY_BE_ARRAY|MAY_BE_OBJECT, NULL)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, updateOptions, IS_ARRAY, 0, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, updateOptions, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()
#endif

#if !(PHP_VERSION_ID >= 80000)
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_MongoDB_Driver_BulkWrite_update, 0, 2, IS_VOID, 0)
ZEND_ARG_INFO(0, filter)
ZEND_ARG_INFO(0, newObj)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, updateOptions, IS_ARRAY, 0, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, updateOptions, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()
#endif

Expand Down
6 changes: 3 additions & 3 deletions src/MongoDB/ClientEncryption.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ final class ClientEncryption

final public function __construct(array $options) {}

final public function createDataKey(string $kmsProvider, array $options = []): \MongoDB\BSON\Binary {}
final public function createDataKey(string $kmsProvider, ?array $options = null): \MongoDB\BSON\Binary {}
Copy link
Member

@jmikola jmikola Aug 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it necessary to change the default value from [] to null? Or was this mainly to be consistent with the use of Z_PARAM_ARRAY_OR_NULL in the method implementation?

I had used the following for in my proposed changes for #1339:

#if PHP_VERSION_ID >= 80000
    final public function rewrapManyDataKey(array|object $filter, ?array $options = []): object {}
#else
    /** @param array|object $filter */
    final public function rewrapManyDataKey($filter, ?array $options = []): object {}
#endif

This satisfied a PHPT test I created with an explicit null passed as $options. I'm amenable to changing the stub file to use null as you have here to be consistent, but just wanted to confirm whether it was significant.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was mainly done for consistency, as omitting the parameter and passing an explicit null has the same effect.


#if PHP_VERSION_ID >= 80000
final public function decrypt(\MongoDB\BSON\Binary $value): mixed {}
Expand All @@ -51,10 +51,10 @@ final public function decrypt(\MongoDB\BSON\Binary $value) {}
#endif

#if PHP_VERSION_ID >= 80000
final public function encrypt(mixed $value, array $options = []): \MongoDB\BSON\Binary {}
final public function encrypt(mixed $value, ?array $options = null): \MongoDB\BSON\Binary {}
#else
/** @param mixed $value */
final public function encrypt($value, array $options = []): \MongoDB\BSON\Binary {}
final public function encrypt($value, ?array $options = null): \MongoDB\BSON\Binary {}
#endif

final public function __wakeup(): void {}
Expand Down
8 changes: 4 additions & 4 deletions src/MongoDB/ClientEncryption_arginfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 169e941e986be2158c89ddba5d5f930cb8fa6bfe */
* Stub hash: 09ec24f8af5aba4c88dc3ee4bcc77022d7cc0b9c */

ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_Driver_ClientEncryption___construct, 0, 0, 1)
ZEND_ARG_TYPE_INFO(0, options, IS_ARRAY, 0)
ZEND_END_ARG_INFO()

ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_class_MongoDB_Driver_ClientEncryption_createDataKey, 0, 1, MongoDB\\BSON\\Binary, 0)
ZEND_ARG_TYPE_INFO(0, kmsProvider, IS_STRING, 0)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 0, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()

#if PHP_VERSION_ID >= 80000
Expand All @@ -25,14 +25,14 @@ ZEND_END_ARG_INFO()
#if PHP_VERSION_ID >= 80000
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_class_MongoDB_Driver_ClientEncryption_encrypt, 0, 1, MongoDB\\BSON\\Binary, 0)
ZEND_ARG_TYPE_INFO(0, value, IS_MIXED, 0)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 0, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()
#endif

#if !(PHP_VERSION_ID >= 80000)
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_class_MongoDB_Driver_ClientEncryption_encrypt, 0, 1, MongoDB\\BSON\\Binary, 0)
ZEND_ARG_INFO(0, value)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 0, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()
#endif

Expand Down
4 changes: 2 additions & 2 deletions src/MongoDB/Command.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
final class Command
{
#if PHP_VERSION_ID >= 80000
final public function __construct(array|object $document, array $commandOptions = []) {}
final public function __construct(array|object $document, ?array $commandOptions = null) {}
#else
/** @param array|object $document */
final public function __construct($document, array $commandOptions = []) {}
final public function __construct($document, ?array $commandOptions = null) {}
#endif

final public function __wakeup(): void {}
Expand Down
6 changes: 3 additions & 3 deletions src/MongoDB/Command_arginfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 3902d0f3c6602053c90a7ee4bc97ece0d6534157 */
* Stub hash: e181b2dbea612c11c9318cc302901228e887c559 */

#if PHP_VERSION_ID >= 80000
ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_Driver_Command___construct, 0, 0, 1)
ZEND_ARG_TYPE_MASK(0, document, MAY_BE_ARRAY|MAY_BE_OBJECT, NULL)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, commandOptions, IS_ARRAY, 0, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, commandOptions, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()
#endif

#if !(PHP_VERSION_ID >= 80000)
ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_Driver_Command___construct, 0, 0, 1)
ZEND_ARG_INFO(0, document)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, commandOptions, IS_ARRAY, 0, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, commandOptions, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()
#endif

Expand Down
8 changes: 4 additions & 4 deletions src/MongoDB/Manager.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ final public function executeQuery(string $namespace, Query $query, array|ReadPr
final public function executeQuery(string $namespace, Query $query, $options = null): Cursor {}
#endif

final public function executeReadCommand(string $db, Command $command, array $options = []): Cursor {}
final public function executeReadCommand(string $db, Command $command, ?array $options = null): Cursor {}

final public function executeReadWriteCommand(string $db, Command $command, array $options = []): Cursor {}
final public function executeReadWriteCommand(string $db, Command $command, ?array $options = null): Cursor {}

final public function executeWriteCommand(string $db, Command $command, array $options = []): Cursor {}
final public function executeWriteCommand(string $db, Command $command, ?array $options = null): Cursor {}

#if PHP_VERSION_ID >= 80000
final public function getEncryptedFieldsMap(): array|object|null {}
Expand All @@ -61,7 +61,7 @@ final public function removeSubscriber(Monitoring\Subscriber $subscriber): void

final public function selectServer(?ReadPreference $readPreference = null): Server {}

final public function startSession(array $options = []): Session {}
final public function startSession(?array $options = null): Session {}

final public function __wakeup(): void {}
}
6 changes: 3 additions & 3 deletions src/MongoDB/Manager_arginfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 516a26c70864397ba986d9855f4f876fe84bceb9 */
* Stub hash: 4b4373da62f18f2c3ab6aae78a495ed84adbe09b */

ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_Driver_Manager___construct, 0, 0, 0)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, uri, IS_STRING, 1, "null")
Expand Down Expand Up @@ -66,7 +66,7 @@ ZEND_END_ARG_INFO()
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_class_MongoDB_Driver_Manager_executeReadCommand, 0, 2, MongoDB\\Driver\\Cursor, 0)
ZEND_ARG_TYPE_INFO(0, db, IS_STRING, 0)
ZEND_ARG_OBJ_INFO(0, command, MongoDB\\Driver\\Command, 0)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 0, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 1, "null")
Copy link
Member

@jmikola jmikola Aug 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why this diff was smaller than the stub file. Looks like gen_stub.php is smart enough to reuse arginfo_class_MongoDB_Driver_Manager_executeReadCommand for executeReadWriteCommand and executeWriteCommand.

ZEND_END_ARG_INFO()

#define arginfo_class_MongoDB_Driver_Manager_executeReadWriteCommand arginfo_class_MongoDB_Driver_Manager_executeReadCommand
Expand Down Expand Up @@ -102,7 +102,7 @@ ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_class_MongoDB_Driver_Manager_sele
ZEND_END_ARG_INFO()

ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_class_MongoDB_Driver_Manager_startSession, 0, 0, MongoDB\\Driver\\Session, 0)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 0, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()

ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_MongoDB_Driver_Manager___wakeup, 0, 0, IS_VOID, 0)
Expand Down
4 changes: 2 additions & 2 deletions src/MongoDB/Query.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
final class Query
{
#if PHP_VERSION_ID >= 80000
final public function __construct(array|object $filter, array $queryOptions = []) {}
final public function __construct(array|object $filter, ?array $queryOptions = null) {}
#else
/** @param array|object $filter */
final public function __construct($filter, array $queryOptions = []) {}
final public function __construct($filter, ?array $queryOptions = null) {}
#endif

final public function __wakeup(): void {}
Expand Down
6 changes: 3 additions & 3 deletions src/MongoDB/Query_arginfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: eac6cad75d3e8db014b69888b0d139d09cc5c51e */
* Stub hash: 896baf668a95c03557d6add9c3a0cc528e5a6468 */

#if PHP_VERSION_ID >= 80000
ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_Driver_Query___construct, 0, 0, 1)
ZEND_ARG_TYPE_MASK(0, filter, MAY_BE_ARRAY|MAY_BE_OBJECT, NULL)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, queryOptions, IS_ARRAY, 0, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, queryOptions, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()
#endif

#if !(PHP_VERSION_ID >= 80000)
ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_Driver_Query___construct, 0, 0, 1)
ZEND_ARG_INFO(0, filter)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, queryOptions, IS_ARRAY, 0, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, queryOptions, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()
#endif

Expand Down
6 changes: 3 additions & 3 deletions src/MongoDB/Server.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,11 @@ final public function executeQuery(string $namespace, Query $query, array|ReadPr
final public function executeQuery(string $namespace, Query $query, $options = null): Cursor {}
#endif

final public function executeReadCommand(string $db, Command $command, array $options = []): Cursor {}
final public function executeReadCommand(string $db, Command $command, ?array $options = null): Cursor {}

final public function executeReadWriteCommand(string $db, Command $command, array $options = []): Cursor {}
final public function executeReadWriteCommand(string $db, Command $command, ?array $options = null): Cursor {}

final public function executeWriteCommand(string $db, Command $command, array $options = []): Cursor {}
final public function executeWriteCommand(string $db, Command $command, ?array $options = null): Cursor {}

final public function getHost(): string {}

Expand Down
4 changes: 2 additions & 2 deletions src/MongoDB/Server_arginfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 8c4e8b2bd6a1a5b0047a69ea3cd79399aa474a05 */
* Stub hash: 2b5ae022d2f31086681627e159b792dd92b4929e */

ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_Driver_Server___construct, 0, 0, 0)
ZEND_END_ARG_INFO()
Expand Down Expand Up @@ -55,7 +55,7 @@ ZEND_END_ARG_INFO()
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_class_MongoDB_Driver_Server_executeReadCommand, 0, 2, MongoDB\\Driver\\Cursor, 0)
ZEND_ARG_TYPE_INFO(0, db, IS_STRING, 0)
ZEND_ARG_OBJ_INFO(0, command, MongoDB\\Driver\\Command, 0)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 0, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()

#define arginfo_class_MongoDB_Driver_Server_executeReadWriteCommand arginfo_class_MongoDB_Driver_Server_executeReadCommand
Expand Down
2 changes: 1 addition & 1 deletion src/MongoDB/Session.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ final public function isDirty(): bool {}

final public function isInTransaction(): bool {}

final public function startTransaction(?array $options = []): void {}
final public function startTransaction(?array $options = null): void {}

final public function __wakeup(): void {}
}
4 changes: 2 additions & 2 deletions src/MongoDB/Session_arginfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: fbf742d6b12a1bf6e04201a81b08e3b26b8e261c */
* Stub hash: c6f026b0e22bb1eb53a63956f6c3c40fe99fbd24 */

ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_Driver_Session___construct, 0, 0, 0)
ZEND_END_ARG_INFO()
Expand Down Expand Up @@ -51,7 +51,7 @@ ZEND_END_ARG_INFO()
#define arginfo_class_MongoDB_Driver_Session_isInTransaction arginfo_class_MongoDB_Driver_Session_isDirty

ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_MongoDB_Driver_Session_startTransaction, 0, 0, IS_VOID, 0)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 1, "[]")
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 1, "null")
ZEND_END_ARG_INFO()

#define arginfo_class_MongoDB_Driver_Session___wakeup arginfo_class_MongoDB_Driver_Session_abortTransaction
Expand Down