PHPC-1703: Fix wrong assignment of MONGOC_HAVE_SS_FAMILY #1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @alcaeus and @NattyNarwhal |
jmikola
approved these changes
Oct 22, 2020
alcaeus
added a commit
that referenced
this pull request
Oct 22, 2020
* v1.8: Fix wrong assignment of MONGOC_HAVE_SS_FAMILY (#1169)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-1703. Closes #1168.
@NattyNarwhal pointed out that the check was reversed, and after a bit of critical thinking, I agree.
@jwoehr this should fix your issue. If you want to you can check out the head branch for this PR (or apply the patch manually) and retry compilation.