PHPC-1631: Support PHP 8 #1166
Merged
PHPC-1631: Support PHP 8 #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
force-pushed
the
phpc-1631
branch
3 times, most recently
from
119dff2 to
ccd09a5
Compare
jmikola
force-pushed
the
phpc-1631
branch
2 times, most recently
from
697576d to
10db461
Compare
alcaeus
force-pushed
the
phpc-1631
branch
3 times, most recently
from
28940c8 to
f8de983
Compare
* PHPC-1689: Remove remainder of TSRMLS_* macros * PHPC-1689: Add compatibility macro for PHP 8 object change * PHPC-1689: Replace PHP_CHECK_GCC_ARG with AX_CHECK_COMPILE_FLAG * PHPC-1689: phongo_compat_object_handler_type and macros * PHPC-1689: clone_object handlers * PHPC-1689: compare_object handlers * PHPC-1689: replace zend_hash_init_ex with zend_hash_init * PHPC-1689: get_debug_info and get_properties handlers
alcaeus
approved these changes
Oct 14, 2020
stof
reviewed
Oct 14, 2020
| @@ -502,6 +516,9 @@ void php_phongo_cursor_init_ce(INIT_FUNC_ARGS) /* {{{ */ | |||
| PHONGO_CE_DISABLE_SERIALIZATION(php_phongo_cursor_ce); | |||
| php_phongo_cursor_ce->get_iterator = php_phongo_cursor_get_iterator; | |||
|
|
|||
| #if PHP_VERSION_ID >= 80000 | |||
There was a problem hiding this comment.
why not implementing IteratorAggregate on all PHP versions ?
There was a problem hiding this comment.
Since the internal iterator only exists on PHP 8, we decided to only implement this on PHP 8 for the time being. You can find some more motivation in the original ticket: https://jira.mongodb.org/browse/PHPC-1690.
I may end up revisiting this sooner than later depending on how PHPLIB reacts to these changes.
There was a problem hiding this comment.
hmm, I forgot that the internal iterator is a PHP 8 feature. That's a good reason then 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1631
This is rebased on #1167 for a memory leak fix that turned up while testing.
@alcaeus: When merging, please squash commits into one per issue so various bug fixes get cross-referenced accordingly. The bulk of changes for PHPC-1689 can be rolled up into one commit, though.