Skip to content

Add .editorconfig #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Add .editorconfig #633

merged 4 commits into from
Jan 14, 2021

Conversation

stIncMale
Copy link
Member

@stIncMale stIncMale requested review from rozza and jyemin January 13, 2021 21:09
@stIncMale
Copy link
Member Author

@rozza This is the config that @jyemin uses. You may be using a different one and may want to discuss some of the options. I am fine with any format :)

Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we prune this file to contain config for only the file formats that we actually use?

@stIncMale
Copy link
Member Author

Should we prune this file to contain config for only the file formats that we actually use?

Done. All other sections contain at least one file extension that we have in the repo.

Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks like there are some unnecessary file formats.

.editorconfig Outdated
ij_visual_guides = none
ij_wrap_on_typing = true

[*.css]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this one too as we never edit the css files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have *.js files, and we probably don't edit them. I will remove front-end related file extensions, even if we have such files in the repo.

.editorconfig Outdated
ij_java_wrap_first_method_in_call_chain = false
ij_java_wrap_long_lines = false

[*.less]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are .less files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.editorconfig Outdated
ij_less_use_double_quotes = true
ij_less_value_alignment = 0

[*.sass]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are .sass files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my fault 👎 , I missed the section. The same is true for the *.styl section.

.editorconfig Outdated
ij_scala_wrap_first_method_in_call_chain = false
ij_scala_wrap_long_lines = false

[*.scss]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are .scss files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.editorconfig Outdated
ij_scss_use_double_quotes = true
ij_scss_value_alignment = 0

[*.styl]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are .styl files?

@jyemin
Copy link
Collaborator

jyemin commented Jan 13, 2021

For the HTML-related files, we almost never edit them, and will soon be removing the reference docs from the repository entirely. So not sure if it's worth including edit configs for anything in the reference/landing docs.

What do you think, @rozza

@stIncMale
Copy link
Member Author

I removed front-end related sections. Jeff, thanks for spotting the redundant styl, sass sections!

Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I've changed now use the default intellij styles and a diff doesn't show much difference - so happy with it.

@@ -0,0 +1,716 @@
[*]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion add:

root = true to the start of the file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 , done.

This way tools won't look all the way up to the root path
to find all the applicable configs.

JAVA-3922
@stIncMale stIncMale merged commit f9bf950 into mongodb:master Jan 14, 2021
@stIncMale stIncMale deleted the JAVA-3922 branch January 14, 2021 17:12
jfitzu pushed a commit to nextworld-tools/mongo-java-driver that referenced this pull request Mar 3, 2021
jfitzu added a commit to nextworld-tools/mongo-java-driver that referenced this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants