Fixes SingleItemObservable to emit item only once #631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi MongoDB, @rozza,
I observed what seems to be a tiny bug.
It is about the
SingleItemObservable
class.This class is called in
SingleObservable.scala
fileI figured it out when adding tests and mocking some DB calls, and returning
SingleObservable(aTestValue)
, I always got an exception :As a quick solution I have to use
Observable(aTestValue :: Nil).toSingle
, which is aware of wether it was already completed. This PR is meant to add this into theSingleItemObservable
class.I did not create a JIRA ticket for this, as it is a very tiny issue, but I can if necessary.
Thanks !