Scala: Ensure implicit conversion keeps type fidelity #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting from a BsonDocument to org.bson.Document the scala driver previously used json. The implementation should not rely on the json output format, but rather use the Codecs to do the conversion. JAVA-3916
jyemin
requested changes
Jan 11, 2021
driver-scala/src/test/scala/org/mongodb/scala/ScalaPackageSpec.scala
Outdated
Show resolved
Hide resolved
stIncMale
reviewed
Jan 11, 2021
jyemin
approved these changes
Jan 11, 2021
jyemin
requested review from
stIncMale and
jyemin
and removed request for
jyemin
aaabramov
reviewed
Jan 11, 2021
| val bsonDocument = Document( | ||
| "null" -> BsonNull(), | ||
| "int32" -> BsonInt32(32), | ||
| "int64" -> BsonInt64(64L), |
There was a problem hiding this comment.
I'd change 64L -> Long.MaxValue for reproducing issue in JIRA ticket.
FYI, I am OP of the bug
aaabramov
reviewed
Jan 13, 2021
| "null" -> BsonNull(), | ||
| "int32" -> BsonInt32(32), | ||
| "int64" -> BsonInt64(Long.MaxValue), | ||
| "decimal128" -> BsonDecimal128(128), |
There was a problem hiding this comment.
Also, I would explicitly pass 128.1 as with BsonDouble.
jfitzu
pushed a commit
to nextworld-tools/mongo-java-driver
that referenced
this pull request
Mar 3, 2021
When converting from a BsonDocument to org.bson.Document the scala driver previously used json. The implementation should not rely on the json output format, but rather use the Codecs to do the conversion. JAVA-3916
jfitzu
added a commit
to nextworld-tools/mongo-java-driver
that referenced
this pull request
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting from a BsonDocument to org.bson.Document
the scala driver previously used json. The implementation
should not rely on the json output format, but rather use
the Codecs to do the conversion.
JAVA-3916