Changes for JAVA-3420 #622
Conversation
| @@ -155,10 +155,12 @@ MongoClientOptions.builder() | |||
| .build(); | |||
| ``` | |||
|
|
|||
| ## JVM System Properties for TLS/SSL | |||
| ## Certificates | |||
There was a problem hiding this comment.
This section is relevant only in situations when users want to use the JVM default truststore and keystore, instead of using separate ones when communicating with a MongoDB server (separate truststore/keystore can be specified via javax.net.ssl.SSLContext.init(KeyManager[] km, TrustManager[] tm, SecureRandom random)). I believe it would be useful to reflect this info in the section title and the section content. For example:
Configuring the default truststore and keystore (as an alternative to "Certificates")
One may either configure separate truststores and keystores via javax.net.ssl.SSLContext.init(KeyManager[] km, TrustManager[] tm, SecureRandom random), or use the JVM default ones.
Default truststore (as an alternative to "Certificate authority")
...content suggested in this PR
Default keystore (as an alternative to "Client certificates")
...content suggested in this PR
| For more information on configuring a Java application for TLS/SSL, please | ||
| refer to the [`JSSE Reference Guide`](http://docs.oracle.com/javase/8/docs/technotes/guides/security/jsse/JSS | ||
| ERefGuide.html). | ||
| refer to the [`JSSE Reference Guide`](http://docs.oracle.com/javase/8/docs/technotes/guides/security/jsse/JSSERefGuide.html). |
There was a problem hiding this comment.
We can be more concrete and point to a specific relevant section of the guide: JSSE Reference Guide - Customizing the Default Keystores and Truststores, Store Types, and Store Passwords.
|
@niccottrell, I apologize for breaking this MR while trying to add a new commit to it. The new MR is here #637. It includes the changes you made, my proposed changes from above (with minor modifications), and other improvements. |
|
Thanks for getting those changes through. Much appreciated!
…On Tue, Jan 19, 2021 at 12:52 AM Valentin Kovalenko < ***@***.***> wrote:
@niccottrell <https://github.com/niccottrell>, I apologize for breaking
this MR while trying to add a new commit to it. The new MR is here #637
<#637>. It includes the
changes you made, my proposed changes from above (with minor
modifications), and other improvements.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#622 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGPRLQYUTH22G7NEYDO5JLS2TCTNANCNFSM4VVAA6CA>
.
--
*{* name : "Nic Cottrell",
title : "Program Manager, Technical Services",
phone : "+33 6 76 59 21 07",
location : "Normandy, France" *}*
|
New PR for https://jira.mongodb.org/browse/JAVA-3420