Skip to content

Store computedServerSelectionTimeout so it can be reused. #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

rozza
Copy link
Member

@rozza rozza commented Feb 21, 2024

Needed for use with authentication

JAVA-5211

@rozza rozza requested a review from vbabanin February 21, 2024 11:00
@rozza rozza marked this pull request as draft February 21, 2024 16:27
@rozza rozza force-pushed the JAVA-5211 branch 2 times, most recently from d42c43d to 7a2b8c1 Compare February 27, 2024 15:21
Needed for use with authentication

JAVA-5211
@rozza rozza marked this pull request as ready for review February 28, 2024 13:58
@rozza
Copy link
Member Author

rozza commented Feb 28, 2024

@vbabanin this is now ready for review. AFAICT the failed tests look like other issues - failed server selections within time (socket exceptions) or other issues.

Copy link
Member

@vbabanin vbabanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one optional nit.

@rozza rozza merged commit d5acd00 into mongodb:CSOT Mar 4, 2024
@rozza rozza deleted the JAVA-5211 branch March 4, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants