Added operation context to authentication #1298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbabanin
reviewed
Jan 30, 2024
jyemin
reviewed
Feb 2, 2024
| @@ -182,6 +182,9 @@ private void doAdvanceOrThrow(final Throwable attemptException, | |||
| final boolean onlyRuntimeExceptions) throws Throwable { | |||
| assertTrue(attempt() < attempts); | |||
| assertNotNull(attemptException); | |||
| if (attemptException instanceof MongoOperationTimeoutException) { | |||
There was a problem hiding this comment.
This conditional seems unrelated to the rest of the PR. What's the intention of including it?
There was a problem hiding this comment.
Had a test failing due to the wrapping of the exception that later occurs.
vbabanin
reviewed
Feb 5, 2024
...ync/src/test/functional/com/mongodb/client/AbstractClientSideOperationsTimeoutProseTest.java
Show resolved
Hide resolved
vbabanin
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5211