Make NettyStreamFactoryFactory implement AutoCloseable #1244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since StreamFactoryFactory is now internal, just made that interface extend AutoCloseable in order to simplify MongoClients code JAVA-5158
Using |
jyemin
added a commit
that referenced
this pull request
Dec 4, 2023
Since StreamFactoryFactory is now internal, just made that interface extend AutoCloseable in order to simplify MongoClients code JAVA-5158
jyemin
added a commit
that referenced
this pull request
Dec 5, 2023
Since StreamFactoryFactory is now internal, just made that interface extend AutoCloseable in order to simplify MongoClients code JAVA-5158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since StreamFactoryFactory is now internal, just made that interface extend AutoCloseable in order to simplify MongoClients code
JAVA-5158
Note: If TransportSettings are used with the synchronous MongoClient, it currently won't close the StreamFactoryFactory. That will require a bit more refactoring than I wanted to do in this PR, and is not likely to be encountered by actual users, as there's no good reason that I know of to use Netty with the synchronous MongoClient.