Make ServerSelectionLoggingTest pass when run against a load balanced cluster, or when using Unix domain socket
#1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed cluster, or when using Unix domain socket JAVA-4754
stIncMale
commented
Nov 2, 2023
| switch (newType) { | ||
| case "Unknown": | ||
| return event.getNewDescription().getType() == ServerType.UNKNOWN; | ||
| case "LoadBalancer": { | ||
| return event.getNewDescription().getType() == ServerType.LOAD_BALANCER; | ||
| } |
There was a problem hiding this comment.
There was a problem hiding this comment.
No, not initially. Hopefully, together with the new logging code it will.
stIncMale
commented
Nov 2, 2023
Comment on lines
+251
to
+254
| if (getMongoClientSettings().getClusterSettings() | ||
| .getHosts().stream().anyMatch(serverAddress -> serverAddress instanceof UnixServerAddress)) { | ||
| tweaks.add(LogMatcher.Tweak.skip(LogMessage.Entry.Name.SERVER_PORT)); | ||
| } |
There was a problem hiding this comment.
JAVA-4754
JAVA-4754
…erver selection JAVA-4754
jyemin
reviewed
Nov 2, 2023
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java
Show resolved
Hide resolved
jyemin
approved these changes
Nov 2, 2023
|
Rebased into two commits and merged on command line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested review from the same reviewers who reviewed the original #1221.
Note that the Evergreen patch for this PR includes the
serverless-testandsocket-testEvergreen tasks (they are not normally included, here they are included manually), which failed in Spruce. This PR fixes those failures.JAVA-4754