Skip to content

CSHARP-4416: Remove getNonce command usage for 6.2+. #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2022
Merged

CSHARP-4416: Remove getNonce command usage for 6.2+. #997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion specifications/command-logging-and-monitoring/tests/logging/redacted-commands.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,11 @@
},
{
"description": "getnonce command and server reply are redacted",
"runOnRequirements": [
{
"maxServerVersion": "6.1.99"
}
],
"operations": [
{
"name": "runCommand",
Expand Down Expand Up @@ -443,6 +448,11 @@
},
{
"description": "network error in response to getnonce is not redacted",
"runOnRequirements": [
{
"maxServerVersion": "6.1.99"
}
],
"operations": [
{
"name": "failPoint",
Expand Down Expand Up @@ -753,6 +763,11 @@
},
{
"description": "copydbgetnonce command and resulting server-generated error are redacted",
"runOnRequirements": [
{
"maxServerVersion": "3.6.99"
}
],
"operations": [
{
"name": "runCommand",
Expand Down Expand Up @@ -804,7 +819,7 @@
"description": "network error in response to copydbgetnonce is not redacted",
"runOnRequirements": [
{
"maxServerVersion": "4.0.99"
"maxServerVersion": "3.6.99"
}
],
"operations": [
Expand Down Expand Up @@ -875,6 +890,11 @@
},
{
"description": "copydbsaslstart command and resulting server-generated error are redacted",
"runOnRequirements": [
{
"maxServerVersion": "4.0.99"
}
],
"operations": [
{
"name": "runCommand",
Expand Down Expand Up @@ -997,6 +1017,11 @@
},
{
"description": "copydb command and resulting server-generated error are redacted",
"runOnRequirements": [
{
"maxServerVersion": "4.0.99"
}
],
"operations": [
{
"name": "runCommand",
Expand Down
16 changes: 13 additions & 3 deletions specifications/command-logging-and-monitoring/tests/logging/redacted-commands.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,8 @@ tests:
failure: { $$exists: true }

- description: "getnonce command and server reply are redacted"
runOnRequirements:
- maxServerVersion: 6.1.99 # getnonce removed as of 6.2 via SERVER-71007
operations:
- name: runCommand
object: *database
Expand Down Expand Up @@ -268,6 +270,8 @@ tests:
$$matchAsDocument: {}

- description: "network error in response to getnonce is not redacted"
runOnRequirements:
- maxServerVersion: 6.1.99 # getnonce removed as of 6.2 via SERVER-71007
operations:
- name: failPoint
object: testRunner
Expand Down Expand Up @@ -453,6 +457,8 @@ tests:
failure: { $$exists: true }

- description: "copydbgetnonce command and resulting server-generated error are redacted"
runOnRequirements:
- maxServerVersion: 3.6.99 # copydbgetnonce was removed as of 4.0 via SERVER-32276
operations:
- name: runCommand
object: *database
Expand Down Expand Up @@ -483,7 +489,7 @@ tests:

- description: "network error in response to copydbgetnonce is not redacted"
runOnRequirements:
- maxServerVersion: "4.0.99" # this commmand was removed in MongoDB 4.2 and the server returns CommandNotFound before hitting the failpoint
- maxServerVersion: 3.6.99 # copydbgetnonce was removed as of 4.0 via SERVER-32276
operations:
- name: failPoint
object: testRunner
Expand Down Expand Up @@ -523,6 +529,8 @@ tests:
failure: { $$exists: true }

- description: "copydbsaslstart command and resulting server-generated error are redacted"
runOnRequirements:
- maxServerVersion: 4.0.99 # copydbsaslstart was removed as of 4.2 via SERVER-36211
operations:
- name: runCommand
object: *database
Expand Down Expand Up @@ -553,7 +561,7 @@ tests:

- description: "network error in response to copydbsaslstart is not redacted"
runOnRequirements:
- maxServerVersion: "4.0.99" # this commmand was removed in MongoDB 4.2 and the server returns CommandNotFound before hitting the failpoint
- maxServerVersion: 4.0.99 # copydbsaslstart was removed as of 4.2 via SERVER-36211
operations:
- name: failPoint
object: testRunner
Expand Down Expand Up @@ -593,6 +601,8 @@ tests:
failure: { $$exists: true }

- description: "copydb command and resulting server-generated error are redacted"
runOnRequirements:
- maxServerVersion: 4.0.99 # copydb was removed as of 4.2 via SERVER-36257
operations:
- name: runCommand
object: *database
Expand Down Expand Up @@ -623,7 +633,7 @@ tests:

- description: "network error in response to copydb is not redacted"
runOnRequirements:
- maxServerVersion: "4.0.99" # this commmand was removed in MongoDB 4.2 and the server returns CommandNotFound before hitting the failpoint
- maxServerVersion: 4.0.99 # copydb was removed as of 4.2 via SERVER-36257
operations:
- name: failPoint
object: testRunner
Expand Down
5 changes: 5 additions & 0 deletions specifications/command-logging-and-monitoring/tests/unified/redacted-commands.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,11 @@
},
{
"description": "getnonce",
"runOnRequirements": [
{
"maxServerVersion": "6.1.99"
}
],
"operations": [
{
"name": "runCommand",
Expand Down
2 changes: 2 additions & 0 deletions specifications/command-logging-and-monitoring/tests/unified/redacted-commands.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ tests:
payload: { $$exists: false }

- description: "getnonce"
runOnRequirements:
- maxServerVersion: "6.1.99"
operations:
- name: runCommand
object: *database
Expand Down
15 changes: 15 additions & 0 deletions specifications/unified-test-format/tests/valid-pass/observeSensitiveCommands.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@
"tests": [
{
"description": "getnonce is observed with observeSensitiveCommands=true",
"runOnRequirements": [
{
"maxServerVersion": "6.1.99"
}
],
"operations": [
{
"name": "runCommand",
Expand Down Expand Up @@ -106,6 +111,11 @@
},
{
"description": "getnonce is not observed with observeSensitiveCommands=false",
"runOnRequirements": [
{
"maxServerVersion": "6.1.99"
}
],
"operations": [
{
"name": "runCommand",
Expand All @@ -127,6 +137,11 @@
},
{
"description": "getnonce is not observed by default",
"runOnRequirements": [
{
"maxServerVersion": "6.1.99"
}
],
"operations": [
{
"name": "runCommand",
Expand Down
6 changes: 6 additions & 0 deletions specifications/unified-test-format/tests/valid-pass/observeSensitiveCommands.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ createEntities:

tests:
- description: "getnonce is observed with observeSensitiveCommands=true"
runOnRequirements:
- maxServerVersion: 6.1.99 # getnonce removed as of 6.2 via SERVER-71007
operations:
- name: runCommand
object: *databaseObserveSensitiveCommands
Expand All @@ -57,6 +59,8 @@ tests:
nonce: { $$exists: false }

- description: "getnonce is not observed with observeSensitiveCommands=false"
runOnRequirements:
- maxServerVersion: 6.1.99 # getnonce removed as of 6.2 via SERVER-71007
operations:
- name: runCommand
object: *databaseDoNotObserveSensitiveCommands
Expand All @@ -68,6 +72,8 @@ tests:
events: []

- description: "getnonce is not observed by default"
runOnRequirements:
- maxServerVersion: 6.1.99 # getnonce removed as of 6.2 via SERVER-71007
operations:
- name: runCommand
object: *databaseDoNotObserveSensitiveCommandsByDefault
Expand Down