CSHARP-5009: Investigate changes in SERVER-85756: rename rangePreview to range #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BorisDog
commented
Mar 19, 2024
BorisDog
commented
- Disable preview range tests on 8.0
… to range CSHARP-5009: Investigate changes in SERVER-85756: rename rangePreview to range
adelinowona
requested changes
Mar 19, 2024
| @@ -64,7 +64,7 @@ public void SupportedWireVersionRange_should_return_expected_result() | |||
| { | |||
| var result = Cluster.SupportedWireVersionRange; | |||
|
|
|||
| result.Should().Be(new Range<int>(6, 23)); | |||
| result.Should().Be(new Range<int>(6, 24)); | |||
There was a problem hiding this comment.
Should this be 25? Given we have wire version 25 associated with Server 8.0 in the codebase.
There was a problem hiding this comment.
Good question. Officially we are not supporting 8.0 features yet, and I only need it to set the max supported version of preview-range features.
So I think we should change SupportedWireVersionRange when we introduce 8.0 support.
| @@ -46,7 +46,7 @@ public void GetServerVersionForErrorMessage_should_return_expected_serverVersion | |||
| [Fact] | |||
| public void SupportedWireRange_should_be_correct() | |||
| { | |||
| WireVersion.SupportedWireVersionRange.Should().Be(new Range<int>(6, 23)); | |||
| WireVersion.SupportedWireVersionRange.Should().Be(new Range<int>(6, 24)); | |||
There was a problem hiding this comment.
Similar comment as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.