CSHARP-3745: Add support for srvServiceName URI option #1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisDog
requested changes
Mar 8, 2024
| @@ -928,6 +937,11 @@ private void Parse() | |||
| throw new MongoConfigurationException("Specifying srvMaxHosts when connecting to a replica set is invalid."); | |||
| } | |||
|
|
|||
| if (!_isInternalRepresentation && _srvServiceName != null && _scheme != ConnectionStringScheme.MongoDBPlusSrv) | |||
There was a problem hiding this comment.
Not very clear from the flow, why do we limit this check to _isInternalRepresentation ?
There was a problem hiding this comment.
So _isInternalRepresentation helps to differentiate between a connection string provided by the user and one that has been transformed into a mongodb:// after the SRV and TXT records are resolved from DNS. So we need to check the connection string before the transformation has happened.
src/MongoDB.Driver/MongoDefaults.cs
Outdated
| /// <summary> | ||
| /// Gets the SRV service name. | ||
| /// </summary> | ||
| public static string SrvServiceName |
There was a problem hiding this comment.
Maybe place it in MongoInternalDefaults and reuse in ConnectionString ?
tests/MongoDB.Driver.Core.Tests/Core/Configuration/ClusterSettingsTests.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
srvServiceNamewhich allows the user to change the srv address prefix from the default ofmongodb