CSHARP-4953: dot-net-driver Evergreen Configuration May Be Leaking Secrets #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
requested review from
rstam,
JamesKovacs and
BorisDog
and removed request for
a team and
rstam
sanych-sun
commented
Mar 1, 2024
| @@ -1916,6 +1942,7 @@ task_groups: | |||
| params: | |||
| file: testazurekms-expansions.yml | |||
| teardown_group: | |||
| - func: upload-test-results | |||
There was a problem hiding this comment.
This change unrelated to leaking secrets, but it fixes missed tests results for some build variants.
BorisDog
reviewed
Mar 1, 2024
BorisDog
approved these changes
Mar 4, 2024
JamesKovacs
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
LGTM
I considered suggesting YAML anchors/aliases to remove the duplication in env var names, but it adds complexity.
You could add a `variables section at the top:
variables:
- fle_env_vars: &fle_env_vars
- "FLE_AWS_ACCESS_KEY_ID"
- "FLE_AWS_SECRET_ACCESS_KEY"
- "FLE_AZURE_TENANT_ID"
- "FLE_AZURE_CLIENT_ID"
- "FLE_AZURE_CLIENT_SECRET"
- "FLE_GCP_EMAIL"
- "FLE_GCP_PRIVATE_KEY"
- other_env_vars: &other_env_vars
- "A"
- "B"
- "C"
And then use it later:
include_expansions_in_env: *fle_env_vars
I'm OK with keeping the repetition and simplicity of the current impl.
sanych-sun
force-pushed
the
evergreen-experiments
branch
from
601e35b to
a870e76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.