Make ThreadingUtilities.ExecuteTasksOnNewThreads await on the operations completion. #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
commented
Feb 27, 2024
| @@ -110,7 +110,7 @@ public static async Task<Exception[]> ExecuteTasksOnNewThreadsCollectExceptions( | |||
| } | |||
| }); | |||
|
|
|||
| var taskAll = Task.WhenAll(allTasks); | |||
| var taskAll = Task.WhenAll(allTasks.Select(t => t.Result)); | |||
There was a problem hiding this comment.
Not sure if this is the best way to fix the problem, but this is the simplest way I could find.
sanych-sun
force-pushed
the
ExecuteTasksOnNewThreads-fix
branch
from
c1c9948 to
f74d209
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test console before the fix:
1 - sync method works as expected.
2 - async method "exit" before inner operations are completed.
Test console after the fix:
both sync and async methods work as expected: