Skip to content

DOCSP-38076 quickstart updates for 11 #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Mar 27, 2024

JIRA:
https://jira.mongodb.org/browse/DOCSP-38076

Staging:

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file
  • Update documentation for new features

Chris Cho added 4 commits March 27, 2024 10:13
Copy link
Contributor

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just requesting changes due to the question I asked


.. tip::

Skip this step if you are using Laravel 10.x since the file that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: I'd switch to "because" (style guide doesn't like "since")

Suggested change
Skip this step if you are using Laravel 10.x since the file that
Skip this step if you are using Laravel 10.x because the file that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Will update.


Open the ``app.php`` file in the ``config`` directory and
add the following entry into the ``providers`` array:
Open the ``providers.php`` file in the ``bootstrap`` directory and add
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: is this the correct file name? I only see an app.php file and a cache folder in the bootstrap directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking.
Yes, this is the correct file and path. I think you might be looking at Laravel 10.x, but this is for 11.x. The Laravel 11.x docs refer to this file here:
https://laravel.com/docs/11.x/providers#registering-providers

@ccho-mongodb ccho-mongodb requested a review from norareidy March 27, 2024 18:34
Copy link
Contributor

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ccho-mongodb ccho-mongodb marked this pull request as ready for review March 27, 2024 18:51
@ccho-mongodb ccho-mongodb requested a review from a team as a code owner March 27, 2024 18:51
@ccho-mongodb ccho-mongodb requested a review from jmikola March 27, 2024 18:51
@jmikola jmikola requested review from GromNaN and removed request for jmikola March 27, 2024 20:44
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccho-mongodb ccho-mongodb merged commit e338fc2 into mongodb:4.2 Apr 3, 2024
@ccho-mongodb ccho-mongodb deleted the DOCSP-38076-quickstart-updates-for-11 branch April 3, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants