DOCSP-35933: Upgrade version guide #2755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-smith721
previously approved these changes
Mar 8, 2024
docs/upgrade.txt
Outdated
| - ``whereDate``, ``whereDay``, ``whereMonth``, ``whereYear``, ``whereTime`` | ||
| now use MongoDB operators on date fields | ||
| A breaking change is a modification in a convention or behavior in | ||
| a specific version of {+odm-short+} that may prevent your application from |
There was a problem hiding this comment.
Suggested change
| a specific version of {+odm-short+} that may prevent your application from | |
| a specific version of {+odm-short+} that might prevent your application from |
docs/upgrade.txt
Outdated
Comment on lines
5
to
7
| =================== | ||
|
|
||
| .. facet:: |
There was a problem hiding this comment.
Can you add the "on this page" directive for the right nav? I think that would be helpful if someone's looking for a certain version
docs/upgrade.txt
Outdated
Comment on lines
87
to
88
| - ``Query\Builder::delete()`` can only delete one or all documents. Ensure that you only pass a value | ||
| of ``1`` or ``null`` to ``limit()``. |
There was a problem hiding this comment.
The use of "only" is a bit tricky here. I think this gets the point across and removes some of the "only" ambiguity.
Suggested change
| - ``Query\Builder::delete()`` can only delete one or all documents. Ensure that you only pass a value | |
| of ``1`` or ``null`` to ``limit()``. | |
| - ``Query\Builder::delete()`` can delete one or all documents. Ensure that you pass only the values | |
| ``1`` or ``null`` to ``limit()``. |
docs/upgrade.txt
Outdated
Comment on lines
97
to
100
| - Removes support for the ``Query\Builder``: ``toSql``, | ||
| ``toRawSql``, ``whereColumn``, ``whereFullText``, ``groupByRaw``, | ||
| ``orderByRaw``, ``unionAll``, ``union``, ``having``, ``havingRaw``, | ||
| ``havingBetween``, ``whereIntegerInRaw``, ``orWhereIntegerInRaw``, |
There was a problem hiding this comment.
I think this might work better as a list so it's not such a big block of methods:
Suggested change
| - Removes support for the ``Query\Builder``: ``toSql``, | |
| ``toRawSql``, ``whereColumn``, ``whereFullText``, ``groupByRaw``, | |
| ``orderByRaw``, ``unionAll``, ``union``, ``having``, ``havingRaw``, | |
| ``havingBetween``, ``whereIntegerInRaw``, ``orWhereIntegerInRaw``, | |
| Removes support for the following ``Query\Builder`` methods: | |
| - ``toSql`` | |
| ... | |
| ... | |
GromNaN
approved these changes
Mar 12, 2024
…ravel-mongodb into DOCSP-35933-upgrade-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA - https://jira.mongodb.org/browse/DOCSP-35933
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/laravel/DOCSP-35933-staging/upgrade/
Checklist