Test Laravel 10 and 11 #2746
Merged
Test Laravel 10 and 11 #2746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
Mar 5, 2024
Yes, but we have to wait for other dependencies to be tagged, like |
GromNaN
force-pushed
the
ci-laravel-11
branch
2 times, most recently
from
2e58716 to
62fe7ca
Compare
|
@alcaeus updated. We have to update the project config to adapt to the new job names. |
|
Updated. While doing that I noticed that this will cause issues with pull requests targeting 4.1, as the new build names won't match there. Since branch protection rules won't properly match, should we target 4.1 with this change (excluding Laravel 11) and then add Laravel 11 after merging up? |
alcaeus
approved these changes
Mar 7, 2024
alcaeus
added a commit
that referenced
this pull request
Mar 13, 2024
* 4.2: PHPORM-139 Implement `Model::createOrFirst()` using `findOneAndUpdate` operation (#2742) Test Laravel 10 and 11 (#2746) PHPORM-150 Run CI on Laravel 11 (#2735) PHPORM-152 Fix tests for Carbon 3 (#2733)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #2735
In order to keep testing Laravel 10 when Laravel 11 will be released, I'm using a variable in the CI that specifies the version of
laravel/framework, which is a meta package containing allilluminatepackages.Checklist
Add tests and ensure they passAdd an entry to the CHANGELOG.md fileUpdate documentation for new features