Check if $primaryKey is present before execute unset #2599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FormigTeen
changed the title
|
Hello @FormigTeen, thank you for the detailed description and the patch. Could you add a non-regression test? The |
GromNaN
approved these changes
Sep 5, 2023
|
Done @GromNaN , Thanks, I closed the other request but if you want I can open it by sending only the test case |
|
Thank you @FormigTeen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Exception on Dissociate Operation for Embed Models in MongoDB
Problem:
Previously, while executing a dissociate operation on Embed Models in MongoDB, an Exception was thrown that prevented the removal of Models. This happened specifically when a Model in the list lacked a $propertyKey.
Solution:
This Pull Request adds a validation check to the dissociate operation for Embed Models in MongoDB. With this fix, the application will now verify if a propertyKey is present in each Model in the list before proceeding with the removal. This resolves the issue of an Exception being thrown during the operation.
Testing
The fix has been thoroughly tested to ensure that the Exception no longer occurs. Now, a model will be successfully dissociated even if another model in the list lacks the $propertyKey.