Remove Eloquent\Builder::chunkById() already having the correct id field in Laravel
#2569
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2569 +/- ##
============================================
- Coverage 90.59% 90.58% -0.02%
+ Complexity 749 748 -1
============================================
Files 34 34
Lines 1787 1785 -2
============================================
- Hits 1619 1617 -2
Misses 168 168
☔ View full report in Codecov by Sentry. |
| $count += count($items); | ||
| $names = []; | ||
| User::chunkById(2, function (EloquentCollection $items) use (&$names) { | ||
| $names = array_merge($names, $items->pluck('name')->all()); |
There was a problem hiding this comment.
I noted your response in GromNaN/laravel-mongodb#25 (comment).
Not sure why I thought + concatenated instead of overwrote for numeric indexes. I certainly confused it with array_merge(), which is what we do need to use here 👍
| */ | ||
| public function chunkById($count, callable $callback, $column = '_id', $alias = null) | ||
| { | ||
| return parent::chunkById($count, $callback, $column, $alias); |
There was a problem hiding this comment.
Noted your response in GromNaN/laravel-mongodb#25 (comment).
I missed that the meaningful change here was removing the _id parameter default value, since Laravel now consults the configured primary key (laravel/framework#28065).
This method was necessary to rename the key name to
_id(MongoDB's default).chunkByIdwas refactored in laravel/framework#28065 to allow custom key name.Reverts #1317