Skip to content

Laravel 10.x Compatibility #2501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Laravel 10.x Compatibility #2501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7807734
Bump dependencies for Laravel 10
laravel-shift Jan 30, 2023
37236c0
chore: update minimum stability
divine Jan 31, 2023
452a0bb
chore: disable php 8.0 in gh builds
divine Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ jobs:
- '4.4'
- '5.0'
php:
- '8.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New laravel doesn't work with php 8.0? Why you delete 8.0 from matrix in CI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/laravel/framework/blob/10.x/composer.json#L18
I suggest to include if condition in ci
If laravel version >= 10.0 then on php 8.0 ci step will be disabled

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- laravel/framework 10.x-dev requires php ^8.1 -> your php version (8.0.27) does not satisfy that requirement.
- illuminate/support 10.x-dev requires php ^8.1 -> your php version (8.0.27) does not satisfy that requirement.

- '8.1'
services:
mysql:
Expand Down
21 changes: 11 additions & 10 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,17 @@
],
"license": "MIT",
"require": {
"illuminate/support": "^9.0",
"illuminate/container": "^9.0",
"illuminate/database": "^9.0",
"illuminate/events": "^9.0",
"mongodb/mongodb": "^1.11"
"illuminate/support": "^10.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to support both Laravel 9.x and 10.x at the same time? I'm not too familiar with the amount of BC breaks that Laravel 10 will bring, but if it's possible to support both without a big hassle, users would profit from that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, that wouldn't be possible there are indeed BC. Upgrading to the latest version of Laravel would be better for the users instead of staying on the older version.

"illuminate/container": "^10.0",
"illuminate/database": "^10.0",
"illuminate/events": "^10.0",
"mongodb/mongodb": "^1.15"
},
"require-dev": {
"phpunit/phpunit": "^9.5.8",
"orchestra/testbench": "^7.0",
"mockery/mockery": "^1.3.1",
"doctrine/dbal": "^2.13.3|^3.1.4"
"phpunit/phpunit": "^9.5.10",
"orchestra/testbench": "^8.0",
"mockery/mockery": "^1.4.4",
"doctrine/dbal": "^3.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: we should try to get rid of this dependency. With Laravel itself no longer depending on it, we should be able to drop the dependency as well at some point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get rid of a lot things, library needs a complete revamp even though the new version of Laravel comes soon.

},
"autoload": {
"psr-4": {
Expand All @@ -54,5 +54,6 @@
"Jenssegers\\Mongodb\\MongodbQueueServiceProvider"
]
}
}
},
"minimum-stability": "dev"
}