Skip to content

Backport of issue #2127 to tree 3.6 #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

pendexgabo
Copy link

Hello!

first off, thank you for your hard work on this project!

This MR is a "backport" (mostly a C&P) from the issue 2127 to the tree 3.6.

We are running into the same issue with the version in laravel 6.x

@codecov-io
Copy link

codecov-io commented Oct 27, 2020

Codecov Report

Merging #2130 into 3.6 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                3.6    #2130   +/-   ##
=========================================
  Coverage     86.88%   86.88%           
  Complexity      671      671           
=========================================
  Files            31       31           
  Lines          1556     1556           
=========================================
  Hits           1352     1352           
  Misses          204      204           
Impacted Files Coverage Δ Complexity Δ
src/Jenssegers/Mongodb/Query/Builder.php 89.06% <100.00%> (ø) 170.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ff280...4de23e1. Read the comment docs.

@divine
Copy link
Contributor

divine commented Oct 27, 2020

Hello,

First of all, thank you for your contribution.

Yes, we know about this problem and I was planning to update it.

Can you push another PR to backport also for 3.7, otherwise it might become a mess with releases.

Thanks!

@pendexgabo
Copy link
Author

@divine Please take a look to #2131

@divine divine merged commit a2edc86 into mongodb:3.6 Oct 27, 2020
@divine
Copy link
Contributor

divine commented Oct 27, 2020

@pendexgabo thank you for your help!

We do really appreciate your help, I will release new version soon.

Thanks!

@pendexgabo
Copy link
Author

Thanks! credit goes to @hnassr

@divine
Copy link
Contributor

divine commented Oct 27, 2020

Thanks! credit goes to @hnassr

Yes, but backporting is also a work that you've done and you know it takes time!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants