Skip to content

[Updated PR#1468] Fix assertObjectNotHasAttribute cannot test magic attributes #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2020

Conversation

divine
Copy link
Contributor

@divine divine commented Jan 30, 2020

This PR was recreated from #1468 with updated branch or resolved conflicting files.

--

fix tests: assertObjectNotHasAttribute cannot test magic attributes

assertObjectNotHasAttribute() actually tests nothing. Go ahead and change note1 to note2 in tests and you see nothing fails.

@divine divine requested a review from Smolevich January 30, 2020 11:36
@Smolevich Smolevich merged commit 2efa5af into mongodb:master Jan 30, 2020
@divine divine deleted the pr_1468 branch January 30, 2020 13:36
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
[Updated PR#1468] Fix assertObjectNotHasAttribute cannot test magic attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants