When comparing new value to original, take type into account #1509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. In case you are still interested, please check #1664 which uses fromPHP() function for getDirty(). |
|
Should be closed in favor of PR #1664 cc @Smolevich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is called from
getDirty()to determine if a field on a model has been updated. When comparing dates, the types still need to be checked. You may be trying to replace the string “1994-04-01 00:00:00” with a date value of 1994-04-01 00:00:00, and for these two values, comparison with==is true while===is false. If we use==, the value in the database will remain a string instead of updating to a date as we are trying to do.