Skip to content

chore(NODE-3330): added mocha.opts #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 25, 2021
Merged

chore(NODE-3330): added mocha.opts #442

merged 3 commits into from
Jun 25, 2021

Conversation

andymina
Copy link
Contributor

Description

  • Added mocha.opts to /test

@andymina andymina requested a review from emadum June 17, 2021 15:27
@andymina andymina marked this pull request as draft June 17, 2021 15:27
@emadum emadum added the Team Review Needs review from team label Jun 17, 2021
@emadum emadum requested review from nbbeeken and dariakp June 17, 2021 15:58
nbbeeken
nbbeeken suggested changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's delete .mocharc.json here too, next time one of comes around here and needs to change options they'll probably think the json is the place to go but it will have no effect

@emadum emadum marked this pull request as ready for review June 22, 2021 15:24
@andymina andymina requested a review from nbbeeken June 22, 2021 21:02
@emadum emadum merged commit f170d44 into master Jun 25, 2021
@emadum emadum deleted the NODE-3330/add-mocha.opts branch June 25, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emadum emadum emadum approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andymina @emadum @nbbeeken @dariakp