-
Notifications
You must be signed in to change notification settings - Fork 29
DOCSP-45076: Document that count supports different filters from countDocuments #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-ruby ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
source/reference/aggregation.txt
Outdated
method and may not support the same filters. ``countDocuments`` uses the | ||
``$match`` stage of the aggregation pipeline to filter documents. To learn more | ||
about limitations of the ``$match`` stage, see :manual:`$match Restrictions </reference/operator/aggregation/match/#restrictions>` | ||
in the MongoDB Server documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I can't add a source constant to the snooty file without breaking the build – unsure if it's a quirk fo the Ruby driver (I notice that it doesn't have many constants in the snooty file as is).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm not sure why that is. The {+mdb-server+} constant was added in the standardization branch, but I think it's fine to not use the constant here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a small suggestion
source/reference/aggregation.txt
Outdated
method and may not support the same filters. ``countDocuments`` uses the | ||
``$match`` stage of the aggregation pipeline to filter documents. To learn more | ||
about limitations of the ``$match`` stage, see :manual:`$match Restrictions </reference/operator/aggregation/match/#restrictions>` | ||
in the MongoDB Server documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S:
in the MongoDB Server documentation. | |
in the MongoDB Server manual. |
source/reference/aggregation.txt
Outdated
method and may not support the same filters. ``countDocuments`` uses the | ||
``$match`` stage of the aggregation pipeline to filter documents. To learn more | ||
about limitations of the ``$match`` stage, see :manual:`$match Restrictions </reference/operator/aggregation/match/#restrictions>` | ||
in the MongoDB Server documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm not sure why that is. The {+mdb-server+} constant was added in the standardization branch, but I think it's fine to not use the constant here
DOCSP-45076: Document that count supports different filters from countDocuments
DOCSP-45076: Document that count supports different filters from countDocuments
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45076
Staging Links
Self-Review Checklist