DOCSP-31844: redirect all v1.x to current homepage #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccho-mongodb
suggested changes
Aug 11, 2023
There was a problem hiding this comment.
Unless someone mentioned otherwise, I think the v1.x redirects that were removed in this PR should be added back and redirect to ${base}/current/. They may be bookmarked or linked from somewhere else, so this change would avoid 404s for some 1.x links, but not all of them.
ccho-mongodb
approved these changes
Aug 24, 2023
config/redirects
Outdated
Comment on lines
50
to
62
| [v2.0-*]: ${prefix}/${version}/aggregation-framework -> ${base}/${version}/quick-start/ | ||
| [v2.0-*]: ${prefix}/${version}/examples -> ${base}/${version}/quick-start/ | ||
| [v2.0-*]: ${prefix}/${version}/replica-sets -> ${base}/${version}/quick-start/ | ||
| [v2.0-*]: ${prefix}/${version}/read-preference -> ${base}/${version}/quick-start/ | ||
| [v2.0-*]: ${prefix}/${version}/write-concern -> ${base}/${version}/quick-start/ | ||
| [v2.0-*]: ${prefix}/${version}/bulk-write-operations -> ${base}/${version}/quick-start/ | ||
| [v2.0-*]: ${prefix}/${version}/authentication-examples -> ${base}/${version}/quick-start/ | ||
| [v2.0-*]: ${prefix}/${version}/gridfs -> ${base}/${version}/quick-start/ | ||
| [v2.0-*]: ${prefix}/${version}/tailable-cursors -> ${base}/${version}/quick-start/ | ||
| [v2.0-*]: ${prefix}/${version}/web-examples -> ${base}/${version}/quick-start/ | ||
| [v2.0-*]: ${prefix}/${version}/faq -> ${base}/${version}/quick-start/ | ||
| [v2.0-*]: ${prefix}/${version}/style-guide -> ${base}/${version}/quick-start/ | ||
| [v2.0-*]: ${prefix}/${version}/credits -> ${base}/${version}/quick-start/ |
There was a problem hiding this comment.
Issue:
I think this redirects to a redirect for v2.15 and later (see lines 139 and 163).
Suggestion:
- Remove line 163 (redundant with 139)
- Change these to apply only to [v2.0-v2.14]
- For [v2.15-*], add entries for the source urls (left of the arrow) and redirect to the base directory. Although there are some better pages to redirect to, I think it should be sufficient and it seems unnecessary to redirect to the quick start instead of the top level-page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA - https://jira.mongodb.org/browse/DOCSP-31844
Can't test staging, but here are the mut output for the new redirects: