-
Notifications
You must be signed in to change notification settings - Fork 29
Fixes for Snooty build #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're also going to need to add the submodule in 😁. https://github.com/mongodb/docs-ruby/pull/21/files has a good example of what I did for master; you'll need to do the same but with the relevant branch here.
Thanks, added the .gitmodules for the appropriate branch. |
Sorry for the confusion -- the submodule needs to be added using |
Looks good - I've staged and everything seems to be hunky dory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % that odd indentation in the submodule which is mysterious.
.gitmodules
Outdated
[submodule "mongo-ruby-driver"] | ||
path = mongo-ruby-driver | ||
url = https://github.com/mongodb/mongo-ruby-driver.git | ||
branch = 2.18-stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the indentation went weird here, but it still seems to work…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think git seems to have two different behaviors for indenting when using "git submodule add -b" vs "git checkout" in the submodule directory. I fixed the indentation so that it matches for all lines.
Fixes to allow for snooty builds.
Similar changes to be applied to v2.16 and v2.17 branches.