DOCSP-45191: GridFS #118
Merged
DOCSP-45191: GridFS #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-ruby ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mongoKart
requested changes
Jan 7, 2025
comandeo-mongo
approved these changes
Jan 8, 2025
jamis
reviewed
Jan 9, 2025
| collection = database[:restaurants] | ||
|
|
||
| # start-create-bucket | ||
| bucket = Mongo::Grid::FSBucket.new(database) |
There was a problem hiding this comment.
The recommended API for creating a bucket is actually via the #fs method on the database, e.g.:
bucket = database.fs
# or, with options
bucket = database.fs(bucket_name: 'files')Using the `Mongo::Grid::FSBucket`` API directly works, too, but is more verbose and less friendly.
There was a problem hiding this comment.
I can create a follow-up PR to address these comments. Thanks for the eyes!
| # end-upload-files | ||
|
|
||
| # start-retrieve-file-info | ||
| bucket.find().each do |file| |
There was a problem hiding this comment.
Empty parentheses are almost always omitted, by convention, e.g.
bucket.find.each do |file|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45191
Staging Links
Self-Review Checklist