DOCSP-45188: Replace #108
Merged
DOCSP-45188: Replace #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-ruby ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jordan-smith721
approved these changes
Dec 17, 2024
source/write/replace.txt
Outdated
|
|
||
| You must pass the following parameters to the ``replace_one`` method: | ||
|
|
||
| - **Query filter**: Matches which documents to update. To learn |
There was a problem hiding this comment.
S: Matches doesn't seem like the right word in this context imo
Suggested change
| - **Query filter**: Matches which documents to update. To learn | |
| - **Query filter**: Specifies which documents to update. To learn |
source/write/replace.txt
Outdated
Comment on lines
70
to
71
| Replace One Document | ||
| -------------------- |
There was a problem hiding this comment.
Having this heading here made me think the page was missing a Replace Many header or something. Since this whole page is just about the replace_one method, I don't think this header is necessary
There was a problem hiding this comment.
Could also move this change this header to be one level down (with ~~~ instead) and call it Replace Example or something similar
source/write/replace.txt
Outdated
| variables for the operation. Values must be constant or closed | ||
| expressions that don't reference document fields. | ||
|
|
||
| The following code performs the same replace operation as above, but sets the ``upsert`` |
There was a problem hiding this comment.
Style guide - use "preceding" to locate information on a page
Suggested change
| The following code performs the same replace operation as above, but sets the ``upsert`` | |
| The following code performs the same replace operation as the preceding example, but sets the ``upsert`` |
jamis
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45188
Staging Links
Self-Review Checklist