-
Notifications
You must be signed in to change notification settings - Fork 89
(DOCSP-39516): Consolidate Delete page #3336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-39516): Consolidate Delete page #3336
Conversation
✅ Deploy Preview for device-sdk ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Readability for Commit Hash: dc3bdf9 You can see any previous Readability scores (if they exist) by looking Readability scores for changed documents:
For Grade Level, aim for 8 or below. For Reading Ease scores, aim for 60 or above:
For help improving readability, try Hemingway App. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dacharyc, yet again amazing work! You've done an excellent job bringing all of this content together.
Requesting changes for a good number of API ref links that should be updated and one minor instance of "realm" that could go away.
for the objects you want to delete to :dotnet-sdk:`Realm.RemoveRange<T> | ||
<reference/Realms.Realm.html#Realms_Realm_RemoveRange__1_System_Linq_IQueryable___0__>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is broken when rendered. It resolves to /latest/T%3E%3Creference/.../
when it should be /latest/reference/.../
. The <T>
seems to be breaking it, as it is interpreted and not rendered. Do we have a way to escape characters in Snooty roles?
Alternatively, we could remove the argument types from our links, like we do in Dart. I think it's nice to have them though.
To delete all objects of a type, call :dotnet-sdk:`Realm.RemoveAll<T> | ||
<reference/Realms.Realm.html#Realms_Realm_RemoveAll__1>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same character escape issue as I mentioned in the delete-multiple-objects-description
file.
In the following example, we call :dotnet-sdk:`Realm.RemoveRange<T> | ||
<reference/Realms.Realm.html#Realms_Realm_RemoveRange__1_System_Linq_IQueryable___0__>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broken link due to character escaping issue.
source/includes/api-details/java/crud/delete-single-object-description.rst
Outdated
Show resolved
Hide resolved
source/includes/api-details/java/crud/delete-multiple-objects-description.rst
Outdated
Show resolved
Hide resolved
source/includes/api-details/java/crud/delete-all-objects-in-the-database-description.rst
Outdated
Show resolved
Hide resolved
source/includes/api-details/kotlin/crud/delete-remove-elements-from-list-description.rst
Outdated
Show resolved
Hide resolved
source/includes/api-details/kotlin/crud/delete-remove-elements-from-set-description.rst
Outdated
Show resolved
Hide resolved
source/includes/api-details/kotlin/crud/delete-remove-elements-from-set-description.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Kyle Rollins <115574589+krollins-mdb@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you, @dacharyc!
8f7001a
into
mongodb:feature-consolidated-sdk-docs
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/realm/feature-consolidated-sdk-docs/ 🪵 Logs |
Pull Request Info - SDK Docs Consolidation
Jira ticket: https://jira.mongodb.org/browse/DOCSP-39516
Staged Page
Note for reviewer: there are some API description tab sets where one or more tabs is missing a description. That's intentional. In some cases, there is no relevant info to provide because we're missing an example, and in other cases, it's because I needed to provide additional info for one of the languages but didn't have anything relevant to say for the other languages.
Page Source
Add links to every SDK's pages where you got the SDK-specific information:
PR Author Checklist
Before requesting a review for your PR, please check these items:
feature-consolidated-sdk-docs
branch instead ofmaster
Naming
.rst
files comply with the naming guidelinesLinks and Refs
Content
Reviewer Checklist
As a reviewer, please check these items: