Skip to content

DOCSP-47071: Extended JSON #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2025

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented Jun 11, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-47071

Staging Links

  • data-formats/extended-json
  • data-formats
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?
    • Did you add redirects?

    Copy link

    netlify bot commented Jun 11, 2025

    Deploy Preview for docs-php-library ready!

    Name Link
    🔨 Latest commit f815dc4
    🔍 Latest deploy log https://app.netlify.com/projects/docs-php-library/deploys/68502c2b09b10500083f0369
    😎 Deploy Preview https://deploy-preview-268--docs-php-library.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.


    )

    Additional Information
    Copy link
    Collaborator

    @mballard-mdb mballard-mdb Jun 11, 2025

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This link to extended JSON is mentioned under Extended JSON formats, maybe make the main header here just API Documentation?

    Copy link
    Collaborator

    @mcmorisi mcmorisi left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Great job, just one suggestion re: using a sharedinclude!

    Comment on lines +33 to +53
    Extended JSON Formats
    ---------------------

    MongoDB Extended JSON features two string formats to represent BSON data.
    Each format conforms to the `JSON RFC <https://www.rfc-editor.org/rfc/rfc8259>`__
    and meets specific use cases.

    The following table describes each Extended JSON format:

    .. list-table::
    :header-rows: 1
    :stub-columns: 1
    :widths: 10 40

    * - Name
    - Description

    * - **Canonical** or **Extended**
    - | A string format that avoids loss of BSON type information during data conversions.
    | This format prioritizes type preservation at the loss of human-readability and
    interoperability with older formats.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    FYA, I went and made a sharedinclude for a lot of this boilerplate – see the C# Extended JSON page for an example.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Since the shell extended json format doesn't apply here, I won't use the sharedinclude

    Extended JSON Examples
    ~~~~~~~~~~~~~~~~~~~~~~

    The following example shows a document containing an ObjectId, date, and long
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Outside the scope of this issue, but looks like how we format ObjectId isn't consistent in the PHP docs (do we monospace it or not?). Just a callout, don't need to take action on this.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    looks like we mostly monospace it throughout the repos so I'll update!

    Copy link
    Collaborator

    @mcmorisi mcmorisi left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @norareidy norareidy merged commit 1aea063 into mongodb:comp-cov Jun 16, 2025
    7 of 9 checks passed
    @norareidy norareidy requested review from a team June 16, 2025 14:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants