-
Notifications
You must be signed in to change notification settings - Fork 34
DOCSP-41991 What's New #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-41991 What's New #145
Conversation
✅ Deploy Preview for docs-php-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! I left some minor suggestions/comments
source/whats-new.txt
Outdated
- Adds support for MongoDB Server v8.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: you can use the mdb-server constant here (applies to all mentions of MongoDB Server):
- Adds support for MongoDB Server v8.0. | |
- Adds support for {+mdb-server+} v8.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are constants helpful? Does it help with load speeds? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this question, but I think it just helps with consistency (if a product name or syntax changes we wouldn't have to fix it multiple times, for example). Not sure about load speeds but that would make sense.
source/whats-new.txt
Outdated
|
||
- Introduces new :ref:`MongoDB\Collection <api-mongodb-collection-class>` methods | ||
to create and manage :atlas:`Atlas Search indexes </atlas-search>`. Atlas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: since this link takes readers out of the PHP docs, I'd clarify where the link is going. You could remove the link here and add a sentence to the end of this bullet point ("To learn more about Atlas Search indexes, see the :atlas:`Atlas Search documentation `.")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applies to all inline links that go to the Atlas/server docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! What do you think of changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a small suggestion
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-41991
Staging - https://deploy-preview-145--docs-php-library.netlify.app/whats-new/
Self-Review Checklist