Skip to content

DOCSP-41991 What's New #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 24, 2024

Conversation

lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented Sep 19, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41991
Staging - https://deploy-preview-145--docs-php-library.netlify.app/whats-new/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for docs-php-library ready!

Name Link
🔨 Latest commit d6803c4
🔍 Latest deploy log https://app.netlify.com/sites/docs-php-library/deploys/66f2fd1561e66100089eb645
😎 Deploy Preview https://deploy-preview-145--docs-php-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! I left some minor suggestions/comments

- Adds support for MongoDB Server v8.0.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: you can use the mdb-server constant here (applies to all mentions of MongoDB Server):

Suggested change
- Adds support for MongoDB Server v8.0.
- Adds support for {+mdb-server+} v8.0.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are constants helpful? Does it help with load speeds? Thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this question, but I think it just helps with consistency (if a product name or syntax changes we wouldn't have to fix it multiple times, for example). Not sure about load speeds but that would make sense.


- Introduces new :ref:`MongoDB\Collection <api-mongodb-collection-class>` methods
to create and manage :atlas:`Atlas Search indexes </atlas-search>`. Atlas
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: since this link takes readers out of the PHP docs, I'd clarify where the link is going. You could remove the link here and add a sentence to the end of this bullet point ("To learn more about Atlas Search indexes, see the :atlas:`Atlas Search documentation `.")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies to all inline links that go to the Atlas/server docs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! What do you think of changes?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small suggestion

@lindseymoore lindseymoore requested review from a team and GromNaN and removed request for a team September 23, 2024 21:06
@lindseymoore lindseymoore merged commit 6f5cdc7 into mongodb:php-standardization Sep 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants