Skip to content

DOCSP-41995: transaction #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 27, 2024

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Sep 11, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41995
Staging - https://deploy-preview-137--docs-php-library.netlify.app/write/transaction/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for docs-php-library ready!

Name Link
🔨 Latest commit baf5e13
🔍 Latest deploy log https://app.netlify.com/sites/docs-php-library/deploys/66f6c3c76a83580009606978
😎 Deploy Preview https://deploy-preview-137--docs-php-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + some suggestions

@rustagir rustagir requested review from a team and GromNaN and removed request for a team September 11, 2024 20:32
@rustagir
Copy link
Collaborator Author

Hi @GromNaN Please take a look at this PR when you have a moment!

@rustagir rustagir requested a review from jmikola September 26, 2024 20:03
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional word wrap suggestion. Content LGTM.

Comment on lines 107 to 108
transaction was previously ended, or if there is a write
conflict.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
transaction was previously ended, or if there is a write
conflict.
transaction was previously ended, or if there is a write conflict.

If you want to avoid extra wrapping.

@alcaeus alcaeus removed their request for review September 27, 2024 06:20
@rustagir rustagir merged commit 17074d6 into mongodb:php-standardization Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants