Refactor static analysis to work with Netlify #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-php-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
branberry
changed the title
branberry
commented
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
This pull request resolves an issue with Netlify builds. Netlify will attempt to install any dependencies for various languages/frameworks if it detects certain configuration files. This is something we can't turn off, unfortunately. What was happening is that Netlify would attempt to use the
composer.jsonto install dependencies, but due to differences between versions of PHP, this causes Netlify builds to fail.To satisfy both systems, I've introduced a change here to move the
composer.jsontocomposer/composer.json.Apologies for the inconvenience. Please let me know if there's any other way this can be addressed.
Successful static analysis run